Repository navigation
ci: pin the first release after the workspace move - #40
Merged
Merged
Conversation
Per-package last-release-sha is not used for the commit scan, and the empty Release-As: 0.2.0 commit fb23cb4 applies to every path. Set last-release-sha at the top level so the scan stops at v0.4.0, and release grantry as 0.5.0: its features predate the move to grantry/, so the path filter does not count them. Remove both after this release.
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39, which did not change release PR #38. The release-please run log shows three causes:
last-release-shais not used for the commit scan. grantry-redis has no release yet, so release-please scanned all of history for it.fb23cb4(theRelease-As: 0.2.0commit) touches no files, so it applies to every package.featcommits changedsrc/before the move tograntry/, so the path filter doesn't count them for grantry.This PR sets
last-release-shaat the top level, so the scan stops at v0.4.0, and addsrelease-as: 0.5.0for grantry. Expected in #38: grantry 0.5.0 and grantry-redis 0.1.0, with grantry-redis requiringgrantry = "0.5". Remove both settings after the release.The grantry changelog entry will lack the conformance and routes features, because those commits aren't attributed to
grantry/. Add them by hand on the release PR branch before merging.